Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expand nightlies to test after deleting yarn.lock #1317

Closed
wants to merge 1 commit into from

Conversation

vzaidman
Copy link
Contributor

@vzaidman vzaidman commented Aug 9, 2024

expand the matrix of nightlies to test metro with latest packages supported in package.json by:
delete the yarn.lock file -> yarn install -> test

example run:
https://github.com/facebook/metro/actions/runs/10831834248

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 9, 2024
@vzaidman vzaidman force-pushed the nightly-latest-packages-validation branch 15 times, most recently from 8fdd7d2 to bc7e11a Compare August 9, 2024 10:16
.github/workflows/nightly-latest-packages-validation.yml Outdated Show resolved Hide resolved
.github/workflows/nightly-latest-packages-validation.yml Outdated Show resolved Hide resolved
.github/actions/yarn-install/action.yml Outdated Show resolved Hide resolved
.github/actions/yarn-install/action.yml Outdated Show resolved Hide resolved
@vzaidman vzaidman changed the title add nightly-latest-packages-validation [DRAFT] add nightly-latest-packages-validation Aug 9, 2024
@vzaidman vzaidman force-pushed the nightly-latest-packages-validation branch 9 times, most recently from cf6e4b6 to d076a58 Compare September 9, 2024 10:24
@vzaidman vzaidman changed the title [DRAFT] add nightly-latest-packages-validation expand nightlies to test after deleting yarn.lock Sep 9, 2024
@vzaidman vzaidman requested review from huntie and robhogan September 9, 2024 10:45
@vzaidman vzaidman force-pushed the nightly-latest-packages-validation branch from d076a58 to 9665912 Compare September 9, 2024 10:46
@facebook-github-bot
Copy link
Contributor

@vzaidman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62497468

vzaidman added a commit that referenced this pull request Sep 12, 2024
Summary:
expand the matrix of nightlies to test metro with latest packages supported in package.json by:
delete the `yarn.lock` file -> `yarn install` -> test

example run:
https://github.com/facebook/metro/actions/runs/10771317347

Pull Request resolved: #1317

Test Plan: https://github.com/facebook/metro/actions/runs/10771317347

Differential Revision: D62497468

Pulled By: vzaidman
@vzaidman vzaidman force-pushed the nightly-latest-packages-validation branch from 9665912 to fc117ba Compare September 12, 2024 11:12
vzaidman added a commit that referenced this pull request Sep 12, 2024
Summary:
expand the matrix of nightlies to test metro with latest packages supported in package.json by:
delete the `yarn.lock` file -> `yarn install` -> test

example run:
https://github.com/facebook/metro/actions/runs/10771317347

Pull Request resolved: #1317

Test Plan: https://github.com/facebook/metro/actions/runs/10771317347

Differential Revision: D62497468

Pulled By: vzaidman
@vzaidman vzaidman force-pushed the nightly-latest-packages-validation branch from fc117ba to 0cda93f Compare September 12, 2024 11:17
vzaidman added a commit that referenced this pull request Sep 12, 2024
Summary:
expand the matrix of nightlies to test metro with latest packages supported in package.json by:
delete the `yarn.lock` file -> `yarn install` -> test

example run:
https://github.com/facebook/metro/actions/runs/10771317347

Pull Request resolved: #1317

Test Plan: https://github.com/facebook/metro/actions/runs/10771317347

Differential Revision: D62497468

Pulled By: vzaidman
@vzaidman vzaidman force-pushed the nightly-latest-packages-validation branch from 0cda93f to 226f9c6 Compare September 12, 2024 12:54
@facebook-github-bot
Copy link
Contributor

@vzaidman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62497468

vzaidman added a commit that referenced this pull request Sep 12, 2024
Summary:
expand the matrix of nightlies to test metro with latest packages supported in package.json by:
delete the `yarn.lock` file -> `yarn install` -> test

example run:
https://github.com/facebook/metro/actions/runs/10831232816

Pull Request resolved: #1317

Test Plan: https://github.com/facebook/metro/actions/runs/10831232816

Differential Revision: D62497468

Pulled By: vzaidman
@vzaidman vzaidman force-pushed the nightly-latest-packages-validation branch from 226f9c6 to 0a11933 Compare September 12, 2024 13:20
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62497468

vzaidman added a commit that referenced this pull request Sep 12, 2024
Summary:
expand the matrix of nightlies to test metro with latest packages supported in package.json by:
delete the `yarn.lock` file -> `yarn install` -> test

example run:
https://github.com/facebook/metro/actions/runs/10831232816

Pull Request resolved: #1317

Test Plan: https://github.com/facebook/metro/actions/runs/10831232816

Differential Revision: D62497468

Pulled By: vzaidman
@vzaidman vzaidman force-pushed the nightly-latest-packages-validation branch from 0a11933 to 76f4fa7 Compare September 12, 2024 13:28
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62497468

vzaidman added a commit that referenced this pull request Sep 12, 2024
Summary:
expand the matrix of nightlies to test metro with latest packages supported in package.json by:
delete the `yarn.lock` file -> `yarn install` -> test

example run:
https://github.com/facebook/metro/actions/runs/10831834248

Pull Request resolved: #1317

Test Plan: https://github.com/facebook/metro/actions/runs/10831834248

Differential Revision: D62497468

Pulled By: vzaidman
@vzaidman vzaidman force-pushed the nightly-latest-packages-validation branch from 76f4fa7 to cc9c248 Compare September 12, 2024 13:58
Summary:
expand the matrix of nightlies to test metro with latest packages supported in package.json by:
delete the `yarn.lock` file -> `yarn install` -> test

example run:
https://github.com/facebook/metro/actions/runs/10831834248

Pull Request resolved: #1317

Test Plan: https://github.com/facebook/metro/actions/runs/10831834248

Differential Revision: D62497468

Pulled By: vzaidman
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62497468

@facebook-github-bot
Copy link
Contributor

@vzaidman merged this pull request in aab9495.

robhogan pushed a commit that referenced this pull request Sep 16, 2024
Summary:
expand the matrix of nightlies to test metro with latest packages supported in package.json by:
delete the `yarn.lock` file -> `yarn install` -> test

example run:
https://github.com/facebook/metro/actions/runs/10831834248

Pull Request resolved: #1317

Test Plan: https://github.com/facebook/metro/actions/runs/10831834248

Reviewed By: huntie

Differential Revision: D62497468

Pulled By: vzaidman

fbshipit-source-id: 4f8a49ecb47588b612b19c2425147e02eabd408b
@vzaidman vzaidman deleted the nightly-latest-packages-validation branch September 25, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants